chore: make buildkite-get-results skill work with large job numbers#3699
Merged
rickeylev merged 3 commits intobazel-contrib:mainfrom Apr 13, 2026
Merged
chore: make buildkite-get-results skill work with large job numbers#3699rickeylev merged 3 commits intobazel-contrib:mainfrom
rickeylev merged 3 commits intobazel-contrib:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances Buildkite data retrieval by implementing a fallback mechanism to fetch job details from /data/jobs.json when the primary response lacks job records despite a non-zero job count. Additionally, it improves the display of pull request numbers and introduces logging to warn when the number of retrieved jobs does not match the reported statistics. A review comment suggests making the job fallback logic more robust by triggering it whenever the retrieved job count is less than the reported count, rather than only when the list is entirely empty.
.agents/skills/buildkite-get-results/scripts/get_buildkite_results.py
Outdated
Show resolved
Hide resolved
aignas
approved these changes
Apr 12, 2026
.agents/skills/buildkite-get-results/scripts/get_buildkite_results.py
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
Addressed feedback on job list truncation and data parsing simplification. edit: comment generated by bot |
…into fix.get.jobs.skill
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently, buildkite returns incomplete results it there are a large number of jobs.
Vibed out changes to handle such cases.