refactor: split create_providers into separate functions#3695
Open
rickeylev wants to merge 5 commits intobazel-contrib:mainfrom
Open
refactor: split create_providers into separate functions#3695rickeylev wants to merge 5 commits intobazel-contrib:mainfrom
rickeylev wants to merge 5 commits intobazel-contrib:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the provider creation logic in python/private/py_executable.bzl by decomposing the monolithic _create_providers function into several modular helper functions. This change improves the structure of py_executable_base_impl by calling these helpers sequentially. Feedback was provided to ignore the unused builtin_py_info return value in py_executable_base_impl to improve code clarity.
| ) | ||
| _add_provider_py_runtime_info(providers, runtime_details) | ||
| _add_provider_py_cc_link_params_info(providers, cc_details.cc_info_for_propagating) | ||
| py_info, builtin_py_info = _add_provider_py_info( |
Contributor
There was a problem hiding this comment.
The builtin_py_info variable is assigned here but never used in the rest of the function. Since _add_provider_py_info already appends it to the providers list if it exists, you can use _ to ignore the second return value and improve code clarity.
Suggested change
| py_info, builtin_py_info = _add_provider_py_info( | |
| py_info, _ = _add_provider_py_info( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The create_providers function was becoming unwieldy because it was
taking all the args for all the providers. Split it up into separate
functions to make it easier to see what args are going to what
providers and follow the provider creation logic.