Skip to content

chore: better build data error handling #3606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickeylev merged 1 commit into from
Feb 19, 2026
Merged

chore: better build data error handling #3606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions python/private/stage2_bootstrap_template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
COVERAGE_INSTRUMENTED = "%coverage_instrumented%" == "1"

# runfiles-root-relative path to a file with binary-specific build information
# It uses forward slashes, so must be converted for proper usage on Windows.
BUILD_DATA_FILE = "%build_data_file%"

# ===== Template substitutions end =====
Expand All @@ -64,9 +65,23 @@ def get_build_data(self):
import runfiles
except ImportError:
from python.runfiles import runfiles
path = runfiles.Create().Rlocation(self.BUILD_DATA_FILE)
with open(path) as fp:
return fp.read()
rlocation_path = self.BUILD_DATA_FILE
if is_windows():
rlocation_path = rlocation_path.replace("/", "\\")
path = runfiles.Create().Rlocation(rlocation_path)
if is_windows():
path = os.path.normpath(path)
try:
# Use utf-8-sig to handle Windows BOM
with open(path, encoding='utf-8-sig') as fp:
return fp.read()
except Exception as exc:
if hasattr(exc, "add_note"):
exc.add_note(f"runfiles lookup path: {rlocation_path}")
exc.add_note(f"exists: {os.path.exists(path)}")
can_read = os.access(path, os.R_OK)
exc.add_note(f"readable: {can_read}")
raise


sys.modules["bazel_binary_info"] = BazelBinaryInfoModule("bazel_binary_info")
Expand Down