fix: use runfiles_root_path in stage2 bootstrap

[rickeylev]

The %stage2_bootstrap% template variable was getting a value like
main/../repo/bla.py. While most APIs would implicitly process the ../ it's
somewhat confusing and makes textual string matching (such as when looking in
a runfiles manifest) harder.

To fix, use runfiles_root_path helper function, which pre-normalizes the path.

[gemini-code-assist]

Summary of Changes

Hello @rickeylev, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily refines how Python executables handle their bootstrap paths by leveraging a dedicated helper function for runfiles. Additionally, it enhances the robustness of a PowerShell script responsible for writing build data by switching to .NET-based file operations and explicitly managing file permissions.

Highlights

• py_executable.bzl update: The %stage2_bootstrap% template variable population was updated to use the runfiles_root_path helper function, ensuring correct path resolution for Python executables.
• build_data_writer.ps1 refactor: The PowerShell script for writing build data was refactored to use .NET methods for file writing, addressing potential encoding and locking issues, and also added explicit ACL setting for read access.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• python/private/build_data_writer.ps1
  • Collected output lines into an array before writing.
  • Used System.IO.File::WriteAllLines with UTF8 No BOM encoding to write content, mitigating PowerShell's default encoding and file locking behaviors.
  • Added a Test-Path check before attempting to read VersionFilePath and InfoFilePath.
  • Configured file ACLs to grant "Everyone" read access to the output file.
• python/private/py_executable.bzl
  • Replaced the manual string formatting for %stage2_bootstrap% with a call to runfiles_root_path(ctx, stage2_bootstrap.short_path).

Activity

• The pull request is currently marked "DO NOT MERGE" and is awaiting another pull request (fix: build_data_writer.ps1 encoding and ACLs #3604).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request aims to address a critical issue in py_executable.bzl by correctly using runfiles_root_path for stage2_bootstrap and refactors build_data_writer.ps1 to use .NET for improved robustness. However, the explicit ACL granting 'Everyone' read access in build_data_writer.ps1 introduces a potential security risk and compatibility issue. Additionally, an existing vulnerability in python/private/zipapp/zip_main_template.py related to os.chmod on unsanitized paths should be addressed separately.