chore: Mark nodejs_repositories repo rule as reproducible #3896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenmj
requested review from
alexeagle,
gregmagolan,
jbedard and
mattem
as code owners
|
jbedard
reviewed
Feb 2, 2026
| _prepare_node(repository_ctx) | ||
|
|
||
| if hasattr(repository_ctx, "repo_metadata"): | ||
| return repository_ctx.repo_metadata(reproducible = True) |
Collaborator
There was a problem hiding this comment.
Normally reproducible would only be set if all the .download() calls specify the sha256. Maybe _download_node should be changed to return reproducible iff the download call(s) all specify a sha?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking this repo rule as reproducible opts it in to using the remote repository content cache, allowing users to avoid materializing it locally