chore: add vscode bazel container#165
Closed
Aghassi wants to merge 1 commit intobazel-contrib:mainfrom
Closed
Conversation
This change adds the necessary files so that if contributing via vscodespaces you have bazel on your path via bazelisk and don't need to do extra work to set it up
Collaborator
|
Hm, this seems really cool to have things 'just work' when editing on GH, but this is a lot of SLOC for us to maintain that none of us understands |
Contributor
Author
|
Yeah unfortunately that's how VSCodespaces bootstraps. Not sure if there is a cleaner way... it's basically what Microsoft says to do at this point 😭 |
Collaborator
|
Reading recent comments on your upstream issues, I get the sense it's not time for us to adopt this yet. @Aghassi as you know I'm super-keen on the idea though. If we could get this working in a more ergonomic way, I'd love to have every one of our OSS Bazel-related repos contain the codespaces solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the necessary files so that if contributing via
vscodespaces you have bazel on your path via bazelisk and don't
need to do extra work to set it up
I also created an upstream issue for fixes I added to the container
to keep it ergonomic:
microsoft/vscode-dev-containers#1507
microsoft/vscode-dev-containers#1508