refactors es_features to eliminate redundancy and improve maintainabi…#14914
Closed
dmanlfc wants to merge 1 commit intobatocera-linux:masterfrom
Closed
refactors es_features to eliminate redundancy and improve maintainabi…#14914dmanlfc wants to merge 1 commit intobatocera-linux:masterfrom
dmanlfc wants to merge 1 commit intobatocera-linux:masterfrom
Conversation
…lity. - the previous structure required manually copy-pasting a large list of shared: features for nearly every standalone emulator. this made adding or removing a common feature a tedious and error-prone process. - with this change an inheritance model has been implemented: the global: shared: list is now a small, base template of truly universal features (power, video, decorations) that all emulators inherit automatically. libretro-specific features (shaders, latency reduction, AI, etc.) have been moved out of global and are now added to the libretro emulator via a shared_include: list. standalone emulators now only need to specify their differences from the base global set using shared_include: (to add features) or shared_exclude: (to remove them). the batocera-es-system script has been updated to handle this new logic, calculating the final feature set for each emulator.
Collaborator
Author
|
@bryanforbes is seeking a better approach |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lity.
the batocera-es-system script has been updated to handle this new logic, calculating the final feature set for each emulator.