fix: Take into account parent's primaryColumn config when fetching fr…#55
Open
danteBenitez wants to merge 1 commit intobashleigh:masterfrom
Open
fix: Take into account parent's primaryColumn config when fetching fr…#55danteBenitez wants to merge 1 commit intobashleigh:masterfrom
danteBenitez wants to merge 1 commit intobashleigh:masterfrom
Conversation
…om polymorphic child Before, on a child repository's options, we didn't handle the case in which there were multiple parents which had different `primaryColumn` names Now we take such configurations into account. Specifically, we fetch the metadata associated with the parent we are visiting and read its `primaryColumn`. This allows for multiple parents to have different ID names when such situations arise.
danteBenitez
force-pushed
the
honor_primary_column
branch
from
69cc478 to
482c76a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…om polymorphic child
Before, on a child repository's options, we didn't handle the case in which there were multiple parents which had different
primaryColumnnamesNow we take such configurations into account. Specifically, we fetch the metadata associated with the parent we are visiting and read its
primaryColumn. This allows for multiple parents to have different ID names when such situations arise.