Ensure test failure printed if test fails #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When a test failed due to a non-zero exit code,
the FAILURE status was not printed after the test name.
Looked like this:
"Running test_name ... Overall result: FAILURE"
instead of the expected:
"Running test_name ... FAILURE
Overall result: FAILURE"
- Makes the failure reporting consistent and finding failure easier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looked like this:
"
Running test_name ... Overall result: FAILURE"instead of the expected:
"
Running test_name ... FAILURE Overall result: FAILURE"