Skip to content

Ruby 3.4.8#2666

Closed
northeastprince wants to merge 1 commit intobasecamp:mainfrom
northeastprince:ruby-3.4.8
Closed

Ruby 3.4.8#2666
northeastprince wants to merge 1 commit intobasecamp:mainfrom
northeastprince:ruby-3.4.8

Conversation

@northeastprince
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings March 5, 2026 14:59
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s Ruby patch version to align local tooling and container builds, with the lockfile refreshed accordingly.

Changes:

  • Bump Ruby from 3.4.7 to 3.4.8 in .ruby-version and both Docker build configurations.
  • Refresh Gemfile.lock to include the resolved ffi ruby-platform gem and bump unicode-emoji to 4.2.0.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
saas/Dockerfile Updates RUBY_VERSION build arg to 3.4.8 for the SaaS image.
Dockerfile Updates RUBY_VERSION build arg to 3.4.8 for the main production image.
.ruby-version Sets the repo’s Ruby version to 3.4.8.
Gemfile.lock Lockfile refresh: adds ruby-platform ffi (1.17.2) entry and bumps unicode-emoji to 4.2.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot AI review requested due to automatic review settings March 5, 2026 15:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@flavorjones
Copy link
Copy Markdown
Member

Hi @northeastprince Thanks for opening this, However, I would prefer to keep Ruby version bumps distinct from dependency version bumps whenever possible. I'll break this out into a separate pull request.

@flavorjones flavorjones closed this Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants