fix: correct RETH_PRUNING_ARGS condition logic#1114
Open
Arvuno wants to merge 2 commits into
Open
Conversation
added 2 commits
May 31, 2026 14:13
The previous condition '' returns 'x' when the variable is unset, making the check TRUE when it should be FALSE, and vice versa. The correct check is '-n' to test whether the variable is non-empty.
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The condition '${var+x}' returns 'x' when the variable is unset, making the check TRUE when the variable is actually empty — and FALSE when it has a value. This is backwards: pruning args are silently dropped when set, and the echo statement runs with an empty value when unset.
Fix using '${var:-}' with '-n' to correctly test non-empty values.