fix: align engine RPC protocols between mainnet and sepolia configs#1008
Open
fix: align engine RPC protocols between mainnet and sepolia configs#1008
Conversation
.env.sepolia had swapped protocols introduced in base#985: - OP_NODE_L2_ENGINE_RPC was ws:// (should be http://, consistent with mainnet) - BASE_NODE_L2_ENGINE_RPC was http:// (should be ws://, required by base-consensus-entrypoint) The entrypoint script uses string substitution \\\ to derive the health-check URL, which only works correctly when the value starts with ws://. Using http:// causes the node to fail to start on Sepolia. Aligns Sepolia config with Mainnet which has the correct protocol assignments.
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a protocol inconsistency in
.env.sepoliaintroduced in #985, whereOP_NODE_L2_ENGINE_RPCandBASE_NODE_L2_ENGINE_RPChad their protocols swapped compared to.env.mainnet.Root Cause
In commit
e684286(PR #985), the newBASE_NODE_*variables were added to both env files, but with inverted protocols:OP_NODE_L2_ENGINE_RPChttp://ws://❌http://✅BASE_NODE_L2_ENGINE_RPCws://http://❌ws://✅Why This Matters
The
base-consensus-entrypointscript derives the health-check URL using bash string substitution:This substitution only works correctly when
BASE_NODE_L2_ENGINE_RPCstarts withws://. When set tohttp://, the replacement produces no change and the health-check hits the wrong endpoint, preventing the Sepolia node from starting correctly.Changes
.env.sepolia:OP_NODE_L2_ENGINE_RPCws://→http://.env.sepolia:BASE_NODE_L2_ENGINE_RPChttp://→ws://No changes to
.env.mainnet(already correct).