Skip to content

fix(signInWithEthereum): secure SIWE verification with domain/nonce v… #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maho0638 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(signInWithEthereum): secure SIWE verification with domain/nonce v… #1544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 27 additions & 15 deletions docs/base-account/reference/core/capabilities/signInWithEthereum.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ try {
```typescript Backend Verification
import { createPublicClient, http } from 'viem';
import { base } from 'viem/chains';
import { verifySiweMessage } from 'viem/siwe';

const client = createPublicClient({
chain: base,
Expand All @@ -89,11 +90,15 @@ export async function verifyAuthentication(req, res) {

try {
// Verify the signature
const isValid = await client.verifyMessage({
address,
message,
signature
});
// Nonce'u mesajın içinden çıkarıyoruz
const nonce = message.match(/Nonce: (\w+)/)?.[1];
const { isValid } = await verifySiweMessage(client, {
address,
message,
signature,
domain: req.headers.host ?? 'yourapp.com',
nonce: nonce,
});

if (!isValid) {
return res.status(401).json({
Expand Down Expand Up @@ -172,11 +177,14 @@ export async function verifyAuth(req, res) {
}

// Verify signature
const isValid = await client.verifyMessage({
address,
message,
signature
});
// Nonce daha önce 'extractNonceFromMessage' ile çıkarılmıştı
const { isValid } = await verifySiweMessage(client, {
address,
message,
signature,
domain: req.headers.host ?? 'yourapp.com',
nonce: nonce,
});

if (isValid) {
usedNonces.add(nonce);
Expand Down Expand Up @@ -221,11 +229,15 @@ app.post('/auth/verify', async (req, res) => {
}

// Verify signature
const valid = await client.verifyMessage({
address,
message,
signature
});
// Nonce daha önce 'message.match' ile çıkarılmıştı
const { isValid } = await verifySiweMessage(client, {
address,
message,
signature,
domain: req.headers.host ?? 'yourapp.com',
nonce: nonce,
});
const valid = isValid; // Eski kodla uyumlu olması için

if (!valid) {
return res.status(401).json({
Expand Down