Harden SIWE authentication examples#1542
Draft
kozemyrpol wants to merge 1 commit into
Draft
Conversation
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This hardens the Base Account
Authenticate Usersexamples so copied backend code validates the full SIWE intent, not just the cryptographic signature.publicClient.verifySiweMessageinstead ofverifyMessagefor SIWE login verification.domainandnonceinto verification to prevent cross-domain and replay acceptance.parseSiweMessage.Closes #1502.
Notes to reviewers
The minimal snippet keeps
yourapp.comas the placeholder domain, while the Express example readsSIWE_DOMAINwith alocalhost:3000development default.How has it been tested?
git diff --checknode scripts/lint-mdx.js docs/base-account/guides/authenticate-users.mdxwas run; the current repository linter reports existing code-fence false positives on this page, including unchanged closing fences.