fix: replace deprecated docker-compose with docker compose v2 in node setup guide#1298
Open
erhnysr wants to merge 2 commits intobase:masterfrom
Open
fix: replace deprecated docker-compose with docker compose v2 in node setup guide#1298erhnysr wants to merge 2 commits intobase:masterfrom
erhnysr wants to merge 2 commits intobase:masterfrom
Conversation
Adds a clarification note about using the correct RPC endpoint when building on Base.
…ate stale repo links - Replace all instances of 'docker-compose' with 'docker compose' (Compose v2) in run-a-base-node.mdx, matching the syntax used in the node repo's README - Update stale github.com/base-org/node link to github.com/base/node Docker Compose v1 (docker-compose) was deprecated in July 2023 and removed in Docker Desktop 4.33. The node repository README already uses 'docker compose' (v2 syntax) exclusively, so the docs should match.
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
run-a-base-node.mdxto replace deprecateddocker-compose(Compose v1) syntax withdocker compose(Compose v2), and fixes a stale repository link.Changes
docker-compose → docker compose (v2)
Docker Compose v1 (
docker-compose) was deprecated in July 2023 and removed in Docker Desktop 4.33. The base/node repository README already usesdocker compose(v2) exclusively — the docs should match to avoid confusion for node operators.Affected lines in
run-a-base-node.mdx:using docker-compose→using docker composedocker-compose.ymlreference updateddocker-compose up→docker compose upStale repo link
github.com/base-org/node→github.com/base/nodeReferences