Fix template standardization issues and enforce AGENTS.md conventions#700
Open
sethoshi18 wants to merge 3 commits into
Open
Fix template standardization issues and enforce AGENTS.md conventions#700sethoshi18 wants to merge 3 commits into
sethoshi18 wants to merge 3 commits into
Conversation
- Updated `gen-validation` in Base Bridge Partner Template to use macro. - Refactored `BasicScript.s.sol` to correctly implement `MultisigScript`. - Enforced `AGENTS.md` status rules in `READY TO SIGN` for README files.
Collaborator
🟡 Heimdall Review Status
|
leopoldjoy
reviewed
May 26, 2026
| @@ -1,6 +1,6 @@ | |||
| # Update Gas Limit, Elasticity & DA Footprint Gas Scalar in L1 `SystemConfig` | |||
|
|
|||
| Status: TODO[READY TO SIGN|DONE] | |||
Contributor
There was a problem hiding this comment.
These changes you made to the template READMEs are incorrect. Since it's a template, the status should not be set. Please revert all of these.
…dback This reverts the changes to `setup-templates/*/README.md` to keep their original status placeholders, as these are base templates and should not have forced statuses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gen-validationin Base Bridge Partner Template to use macro.BasicScript.s.solto correctly implementMultisigScript.AGENTS.mdstatus rules inREADY TO SIGNfor README files.