Improve naming of clean up configuration instances#429
Merged
Conversation
`cleanHooks` is misleading as a name for `*CleanUpConfiguration` because such a clean up configuration itself has a field `cleanHooks` which lead to code like `this.cleanHooks.runCleanHooks()` before.
philipp94831
previously approved these changes
Mar 11, 2026
streams-bootstrap-core/src/main/java/com/bakdata/kafka/consumer/ConsumerCleanUpRunner.java
Show resolved
Hide resolved
philipp94831
approved these changes
Mar 11, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cleanHooksis misleading as a name for*CleanUpConfigurationbecause such a clean up configuration itself has a fieldcleanHookswhich lead to code likethis.cleanHooks.runCleanHooks()before.