Skip to content

Add sync_results_total metric for replication success/failure#1958

Open
DeanKamali wants to merge 2 commits intobackube:mainfrom
DeanKamali:main
Open

Add sync_results_total metric for replication success/failure#1958
DeanKamali wants to merge 2 commits intobackube:mainfrom
DeanKamali:main

Conversation

@DeanKamali
Copy link
Copy Markdown

@DeanKamali DeanKamali commented Mar 24, 2026

Summary

  • Add new Prometheus metric volsync_sync_results_total to track replication sync success/failure counts
  • Metric labels: obj_name, obj_namespace, role, method, result

Closes #1128

Adds a new prometheus metric volsync_sync_results_total that tracks
the count of successful and failed replication sync operations.
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 24, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DeanKamali
Once this PR has been reviewed and has the lgtm label, please assign tesshuflower for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 24, 2026

Hi @DeanKamali. Thanks for your PR.

I'm waiting for a backube member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the size/M label Mar 24, 2026
Add SyncResultRecorded field to track when RecordSyncResult is called,
matching the pattern of other fakeMachine metrics methods.
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Volsync Direct Replication Success/Failure Metric

1 participant