Skip to content

Refer to ux internal marco instead of using direct tx #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayedm1 wants to merge 1 commit into
base: master
Choose a base branch
from
+968 −919
Open

Refer to ux internal marco instead of using direct tx #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 32 additions & 11 deletions common/core/inc/ux_utility.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,26 +180,31 @@ extern ALIGN_TYPE _ux_utility_time_elapsed(ALIGN_TYPE, ALIGN_TYPE);
#if !defined(UX_STANDALONE)
#define _ux_system_semaphore_create _ux_utility_semaphore_create
#define _ux_system_semaphore_create_norc _ux_utility_semaphore_create
#define _ux_system_semaphore_created(sem) ((sem)->tx_semaphore_id != UX_EMPTY)
#define _ux_system_semaphore_get _ux_utility_semaphore_get
#define _ux_system_semaphore_get_norc _ux_utility_semaphore_get
#define _ux_system_semaphore_waiting(sem) ((sem)->tx_semaphore_count != 0)
#define _ux_system_semaphore_delete _ux_utility_semaphore_delete
#define _ux_system_semaphore_put _ux_utility_semaphore_put
#define _ux_system_thread_create _ux_utility_thread_create
#define _ux_system_thread_create_norc _ux_utility_thread_create
#define _ux_system_thread_created(t) ((t)->tx_thread_id != UX_EMPTY)
#define _ux_system_thread_delete _ux_utility_thread_delete
#define _ux_system_mutex_create _ux_utility_mutex_create
#define _ux_system_mutex_delete _ux_utility_mutex_delete
#define _ux_system_mutex_off _ux_utility_mutex_off
#define _ux_system_mutex_on _ux_utility_mutex_on
#define _ux_system_event_flags_create _ux_utility_event_flags_create
#define _ux_system_event_flags_created(e) ((e)->tx_event_flags_group_id != UX_EMPTY)
#define _ux_system_event_flags_delete _ux_utility_event_flags_delete
#define _ux_system_event_flags_get _ux_utility_event_flags_get
#define _ux_system_event_flags_set _ux_utility_event_flags_set
#define _ux_system_event_flags_set_rc _ux_utility_event_flags_set
#ifdef TX_API_H
#define _ux_system_thread_entry(t) ((t)->tx_thread_entry)
#define _ux_system_thread_created(t) ((t)->tx_thread_id != UX_EMPTY)
#define _ux_system_semaphore_created(sem) ((sem)->tx_semaphore_id != UX_EMPTY)
#define _ux_system_semaphore_waiting(sem) ((sem)->tx_semaphore_count != 0)
#define _ux_system_event_flags_created(e) ((e)->tx_event_flags_group_id != UX_EMPTY)
#define _ux_system_mutex_created(m) ((m)->tx_mutex_id != UX_EMPTY)
#define _ux_system_mutex_suspended_count(m) ((m)->tx_mutex_suspended_count)
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When TX_API_H is not defined, the macro _ux_host_mutex_created is not defined for the non-standalone case. This will cause compilation errors when USBX is used without ThreadX. Similar macros like _ux_system_thread_entry, _ux_system_mutex_created, and _ux_system_mutex_suspended_count also lack fallback definitions when TX_API_H is not defined in the non-standalone UX_STANDALONE case. These macros need fallback definitions that work without ThreadX.

Suggested change
#define _ux_system_mutex_suspended_count(m) ((m)->tx_mutex_suspended_count)
#define _ux_system_mutex_suspended_count(m) ((m)->tx_mutex_suspended_count)
#else
#define _ux_system_thread_entry(t) UX_NULL
#define _ux_system_thread_created(t) (UX_FALSE)
#define _ux_system_semaphore_created(sem) (UX_FALSE)
#define _ux_system_semaphore_waiting(sem) (UX_FALSE)
#define _ux_system_event_flags_created(e) (UX_FALSE)
#define _ux_system_mutex_created(m) (UX_FALSE)
#define _ux_system_mutex_suspended_count(m) (0)

Copilot uses AI. Check for mistakes.
#endif /* TX_API_H */
#else
#define _ux_system_semaphore_create(sem,name,cnt) (UX_SUCCESS)
#define _ux_system_semaphore_create_norc(sem,name,cnt) do{}while(0)
Expand All @@ -223,18 +228,16 @@ extern ALIGN_TYPE _ux_utility_time_elapsed(ALIGN_TYPE, ALIGN_TYPE);
#define _ux_system_event_flags_get(g,req,gopt,actual,wopt) (*actual = 0)
#define _ux_system_event_flags_set(g,flags,option) do{(void)flags;}while(0)
#define _ux_system_event_flags_set_rc(g,flags,option) (UX_SUCCESS)
#define _ux_system_mutex_created(m) (UX_FALSE)
#endif

#if !defined(UX_DEVICE_STANDALONE)
#define _ux_device_thread_create _ux_utility_thread_create
#define _ux_device_thread_delete _ux_utility_thread_delete
#define _ux_device_thread_entry(t) ((t)->tx_thread_entry)
#define _ux_device_thread_suspend _ux_utility_thread_suspend
#define _ux_device_thread_resume _ux_utility_thread_resume
#define _ux_device_thread_relinquish _ux_utility_thread_relinquish
#define _ux_device_semaphore_create _ux_utility_semaphore_create
#define _ux_device_semaphore_created(sem) ((sem)->tx_semaphore_id != 0)
#define _ux_device_semaphore_waiting(sem) ((sem)->tx_semaphore_count != 0)
#define _ux_device_semaphore_delete _ux_utility_semaphore_delete
#define _ux_device_semaphore_get _ux_utility_semaphore_get
#define _ux_device_semaphore_put _ux_utility_semaphore_put
Expand All @@ -246,6 +249,15 @@ extern ALIGN_TYPE _ux_utility_time_elapsed(ALIGN_TYPE, ALIGN_TYPE);
#define _ux_device_event_flags_delete _ux_utility_event_flags_delete
#define _ux_device_event_flags_get _ux_utility_event_flags_get
#define _ux_device_event_flags_set _ux_utility_event_flags_set
#ifdef TX_API_H
#define _ux_device_thread_entry(t) ((t)->tx_thread_entry)
#define _ux_device_thread_created(t) ((t)->tx_thread_id != UX_EMPTY)
#define _ux_device_semaphore_created(sem) ((sem)->tx_semaphore_id != UX_EMPTY)
#define _ux_device_semaphore_waiting(sem) ((sem)->tx_semaphore_count != 0)
#define _ux_device_event_flags_created(e) ((e)->tx_event_flags_group_id != UX_EMPTY)
#define _ux_device_mutex_created(m) ((m)->tx_mutex_id != UX_EMPTY)
#define _ux_device_mutex_suspended_count(m) ((m)->tx_mutex_suspended_count)
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When TX_API_H is not defined, the macros _ux_device_thread_entry, _ux_device_thread_created, _ux_device_semaphore_created, _ux_device_semaphore_waiting, _ux_device_event_flags_created, _ux_device_mutex_created, and _ux_device_mutex_suspended_count are not defined for the non-standalone case. These need fallback definitions for non-ThreadX environments.

Suggested change
#define _ux_device_mutex_suspended_count(m) ((m)->tx_mutex_suspended_count)
#define _ux_device_mutex_suspended_count(m) ((m)->tx_mutex_suspended_count)
#else /* !TX_API_H */
#define _ux_device_thread_entry(t) ((UX_THREAD_ENTRY)t)
#define _ux_device_thread_created(t) (UX_FALSE)
#define _ux_device_semaphore_created(sem) (UX_FALSE)
#define _ux_device_semaphore_waiting(sem) (UX_FALSE)
#define _ux_device_event_flags_created(e) (UX_FALSE)
#define _ux_device_mutex_created(m) (UX_FALSE)
#define _ux_device_mutex_suspended_count(m) (0)

Copilot uses AI. Check for mistakes.
#endif /* TX_API_H */
#else
#define _ux_device_thread_create(t,name,entry,entry_param,stack,stack_size,priority,preempt_threshold,time_slice,auto_start) (UX_SUCCESS)
#define _ux_device_thread_delete(t) do{}while(0)
Expand All @@ -267,20 +279,18 @@ extern ALIGN_TYPE _ux_utility_time_elapsed(ALIGN_TYPE, ALIGN_TYPE);
#define _ux_device_event_flags_delete(g) do{}while(0)
#define _ux_device_event_flags_get(g,req,gopt,actual,wopt) do{}while(0)
#define _ux_device_event_flags_set(g,flags,option) do{}while(0)
#define _ux_device_event_flags_created(e) (UX_FALSE)
#define _ux_device_mutex_created(m) (UX_FALSE)
#endif


#if !defined(UX_HOST_STANDALONE)
#define _ux_host_thread_create _ux_utility_thread_create
#define _ux_host_thread_created(thr) ((thr)->tx_thread_id != 0)
#define _ux_host_thread_delete _ux_utility_thread_delete
#define _ux_host_thread_entry(thr) ((thr)->tx_thread_entry)
#define _ux_host_thread_resume _ux_utility_thread_resume
#define _ux_host_thread_sleep _ux_utility_thread_sleep
#define _ux_host_thread_schedule_other _ux_utility_thread_schedule_other
#define _ux_host_semaphore_create _ux_utility_semaphore_create
#define _ux_host_semaphore_created(sem) ((sem)->tx_semaphore_id != 0)
#define _ux_host_semaphore_waiting(sem) ((sem)->tx_semaphore_count != 0)
#define _ux_host_semaphore_delete _ux_utility_semaphore_delete
#define _ux_host_semaphore_get _ux_utility_semaphore_get
#define _ux_host_semaphore_get_norc _ux_utility_semaphore_get
Expand All @@ -296,6 +306,15 @@ extern ALIGN_TYPE _ux_utility_time_elapsed(ALIGN_TYPE, ALIGN_TYPE);
#define _ux_host_event_flags_set _ux_utility_event_flags_set
#define _ux_host_timer_create _ux_utility_timer_create
#define _ux_host_timer_delete _ux_utility_timer_delete
#ifdef TX_API_H
#define _ux_host_thread_entry(t) ((t)->tx_thread_entry)
#define _ux_host_thread_created(t) ((t)->tx_thread_id != UX_EMPTY)
#define _ux_host_semaphore_created(sem) ((sem)->tx_semaphore_id != UX_EMPTY)
#define _ux_host_semaphore_waiting(sem) ((sem)->tx_semaphore_count != 0)
#define _ux_host_event_flags_created(e) ((e)->tx_event_flags_group_id != UX_EMPTY)
#define _ux_host_mutex_created(m) ((m)->tx_mutex_id != UX_EMPTY)
#define _ux_host_mutex_suspended_count(m) ((m)->tx_mutex_suspended_count)
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When TX_API_H is not defined, the macros _ux_host_thread_entry, _ux_host_thread_created, _ux_host_semaphore_created, _ux_host_semaphore_waiting, _ux_host_event_flags_created, _ux_host_mutex_created, and _ux_host_mutex_suspended_count are not defined for the non-standalone case. These need fallback definitions for non-ThreadX environments.

Suggested change
#define _ux_host_mutex_suspended_count(m) ((m)->tx_mutex_suspended_count)
#define _ux_host_mutex_suspended_count(m) ((m)->tx_mutex_suspended_count)
#else
#define _ux_host_thread_entry(t) (UX_NULL)
#define _ux_host_thread_created(t) (UX_FALSE)
#define _ux_host_semaphore_created(sem) (UX_FALSE)
#define _ux_host_semaphore_waiting(sem) (UX_FALSE)
#define _ux_host_event_flags_created(e) (UX_FALSE)
#define _ux_host_mutex_created(m) (UX_FALSE)
#define _ux_host_mutex_suspended_count(m) (0)

Copilot uses AI. Check for mistakes.
#endif /* TX_API_H */
#else
#define _ux_host_thread_create(t,name,entry,entry_param,stack,stack_size,priority,preempt_threshold,time_slice,auto_start) (UX_SUCCESS)
#define _ux_host_thread_created(t) (UX_FALSE)
Expand All @@ -322,6 +341,8 @@ extern ALIGN_TYPE _ux_utility_time_elapsed(ALIGN_TYPE, ALIGN_TYPE);
#define _ux_host_event_flags_set(g,flags,option) do{}while(0)
#define _ux_host_timer_create(t,name,func,arg,tick0,tick1,flag) (UX_SUCCESS)
#define _ux_host_timer_delete(t) do{}while(0)
#define _ux_host_event_flags_created(e) (UX_FALSE)
#define _ux_host_mutex_created(m) (UX_FALSE)
#endif


Expand Down
Loading
Loading