Skip to content

Fix Ci build issue #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ayedm1 merged 1 commit into from
Jan 14, 2026
Merged

Fix Ci build issue #4

ayedm1 merged 1 commit into from
Jan 14, 2026

Conversation

@ayedm1
Copy link
Owner

@ayedm1 ayedm1 commented Jan 13, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 13, 2026 22:28
@github-actions
Copy link

github-actions bot commented Jan 13, 2026

Test Results

3 030 tests   3 030 ✔️  32m 0s ⏱️
     17 suites         0 💤
     17 files           0 ❌

Results for commit d0136b3.

@github-actions
Copy link

github-actions bot commented Jan 13, 2026

Code Coverage

Package Line Rate Branch Rate Health
core.src 96% 92% ✔
usbx_device_classes.src 97% 91% ✔
usbx_host_classes.src 97% 93% ✔
Summary 97% (7607 / 7873) 92% (3378 / 3661) ✔

Copilot AI reviewed Jan 13, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

ports/cortex_r5/iar/inc/ux_port.h
Comment on lines +220 to +223
#ifndef UX_HOST_CLASS_STORAGE_MAX_PARTITIONS_COUNT
#define UX_HOST_CLASS_STORAGE_MAX_PARTITIONS_COUNT 8
#endif

Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The macro UX_HOST_CLASS_STORAGE_MAX_PARTITIONS_COUNT is defined twice in this file. The first definition is at lines 207-208, and this is a duplicate definition at lines 220-222. Remove this duplicate definition as it causes redundancy and could lead to confusion or compilation warnings.

Suggested change
#ifndef UX_HOST_CLASS_STORAGE_MAX_PARTITIONS_COUNT
#define UX_HOST_CLASS_STORAGE_MAX_PARTITIONS_COUNT 8
#endif

Copilot uses AI. Check for mistakes.
ports/cortex_r5/gnu/inc/ux_port.h
Comment on lines +220 to +223
#ifndef UX_HOST_CLASS_STORAGE_MAX_PARTITIONS_COUNT
#define UX_HOST_CLASS_STORAGE_MAX_PARTITIONS_COUNT 8
#endif

Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The macro UX_HOST_CLASS_STORAGE_MAX_PARTITIONS_COUNT is defined twice in this file. The first definition is at lines 207-208, and this is a duplicate definition at lines 220-222. Remove this duplicate definition as it causes redundancy and could lead to confusion or compilation warnings.

Suggested change
#ifndef UX_HOST_CLASS_STORAGE_MAX_PARTITIONS_COUNT
#define UX_HOST_CLASS_STORAGE_MAX_PARTITIONS_COUNT 8
#endif

Copilot uses AI. Check for mistakes.
ports/cortex_r4/iar/inc/ux_port.h
Comment on lines +220 to +223
#ifndef UX_HOST_CLASS_STORAGE_MAX_PARTITIONS_COUNT
#define UX_HOST_CLASS_STORAGE_MAX_PARTITIONS_COUNT 8
#endif

Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The macro UX_HOST_CLASS_STORAGE_MAX_PARTITIONS_COUNT is defined twice in this file. The first definition is at lines 207-208, and this is a duplicate definition at lines 220-222. Remove this duplicate definition as it causes redundancy and could lead to confusion or compilation warnings.

Suggested change
#ifndef UX_HOST_CLASS_STORAGE_MAX_PARTITIONS_COUNT
#define UX_HOST_CLASS_STORAGE_MAX_PARTITIONS_COUNT 8
#endif

Copilot uses AI. Check for mistakes.
ports/cortex_r4/gnu/inc/ux_port.h
Comment on lines +220 to +223
#ifndef UX_HOST_CLASS_STORAGE_MAX_PARTITIONS_COUNT
#define UX_HOST_CLASS_STORAGE_MAX_PARTITIONS_COUNT 8
#endif

Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The macro UX_HOST_CLASS_STORAGE_MAX_PARTITIONS_COUNT is defined twice in this file. The first definition is at lines 207-208, and this is a duplicate definition at lines 220-222. Remove this duplicate definition as it causes redundancy and could lead to confusion or compilation warnings.

Suggested change
#ifndef UX_HOST_CLASS_STORAGE_MAX_PARTITIONS_COUNT
#define UX_HOST_CLASS_STORAGE_MAX_PARTITIONS_COUNT 8
#endif

Copilot uses AI. Check for mistakes.
@ayedm1 ayedm1 merged commit fa1d17a into master Jan 14, 2026
11 checks passed
@ayedm1 ayedm1 deleted the fix_ci_compilation branch January 14, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ayedm1