New unified stream manager #509
Open
+686
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
DmitriyMusatkin
approved these changes
Jan 23, 2026
| || connectionManagerOptions.getTlsContext() != null) && priorKnowledge) { | ||
| URI uri = connectionManagerOptions.getUri(); | ||
| boolean useTls = HTTPS.equals(uri.getScheme()); | ||
| if (useTls && priorKnowledge) { |
Contributor
There was a problem hiding this comment.
is this java only limitation? should we check it on native side instead?
Contributor
Author
There was a problem hiding this comment.
we do check it in C. I think this is for checking the options in java so that it can throw a better exceptions directly in Java?
Looks like it was the pattern we used in the connection managers as well. https://github.com/awslabs/aws-crt-java/pull/436/changes#diff-cf32dbe053c97dc09c87d3363e5234d15462c8d60baefda59cd8c6bdcba4db6e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.