Draft
Conversation
DavidSouther
suggested changes
Sep 21, 2024
Contributor
There was a problem hiding this comment.
This is a ton of wrapper code around git. I don't love that it's all in Python using subprocess and os.path for several reasons (looks like some shell injection avenues, we prefer using Path from pathlib, etc). Could you look at what it would take to have this use GitPython instead? https://gitpython.readthedocs.io/en/stable/
Or rewrite it in Bash, this would be like 20 lines of shell script.
Contributor
There was a problem hiding this comment.
What do you think about https://github.com/DavidSouther/shgit for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the working script last used to get metrics for our tributaries. Must be run locally with AWS network access.