Adding Jest test and pipeline output location change

.editorconfig

@@ -7,3 +7,6 @@ root = true
 [*]
 end_of_line = lf
 insert_final_newline = true
+charset = utf-8
+indent_style = space
+tab_width = 2

.gitignore

@@ -2,9 +2,40 @@
 !jest.config.js
 !.eslintrc.js
 !.prettierrc.js
+
+!lib/**/*.ts
+!test/**/*.ts
 *.d.ts
-node_modules
+
 dist
+node_modules
+
+# yarn asset
+yarn-install.log
+.yarn/*
+!.yarn/releases/
+!.yarn/plugins/
+!.yarn/versions/
+!.yarn/sdks/
+.pnp.*
+
+# yarn asset
+yarn-install.log
+.yarn/*
+!.yarn/releases/
+!.yarn/plugins/
+!.yarn/versions/
+!.yarn/sdks/
+.pnp.*
+
+# yarn asset
+yarn-install.log
+.yarn/*
+!.yarn/releases/
+!.yarn/plugins/
+!.yarn/versions/
+!.yarn/sdks/
+.pnp.*
 
 # yarn asset
 yarn-install.log
@@ -28,3 +59,4 @@ cdk.context.json
 
 assets
 source-zip
+aws4embeddedlinux-cdk-lib-*.tgz

.npmignore

@@ -1,6 +1,18 @@
-*.ts
-!*.d.ts
+.yarn
+.github
+.vscode
+test
 
-# CDK asset staging directory
-.cdk.staging
-cdk.out
+.editorconfig
+.gitattributes
+.pre-commit-config.yaml
+eslint.config.mjs
+jest.config.js
+typedoc.json
+tsconfig.*.json
+package-lock.json
+yarn.lock
+
+CODE_OF_CONDUCT.md
+CONTRIBUTING.md
+SECURITY.md

.vscode/settings.json

@@ -0,0 +1,7 @@
+{
+  "eslint.alwaysShowStatus": true,
+  "editor.codeActionsOnSave": {
+    "source.fixAll.eslint": true
+  },
+  "explorer.autoReveal": false
+}

README.md

@@ -213,7 +213,7 @@ npm install aws4embeddedlinux/aws4embeddedlinux-ci
 of `yarn':
 
 ```bash
-yarn add github:aws4embeddedlinux/aws4embeddedlinux-ci
+yarn add aws4embeddedlinux-cdk-lib@aws4embeddedlinux/aws4embeddedlinux-ci
 yarn install
 ```
 
@@ -254,7 +254,7 @@ const projectPipeline = new EmbeddedLinuxCodePipelineStack(app, "demo-project",
 });
 ```
 
-Refer to the [API Documentation](https://aws4embeddedlinux.github.io/aws4embeddedlinux-ci) and the [sample](github.com/aws4embeddedlinux/aws4embeddedlinux-ci-examples) for more details.
+Refer to the [API Documentation](https://aws4embeddedlinux.github.io/aws4embeddedlinux-ci) and the [sample](https://github.com/aws4embeddedlinux/aws4embeddedlinux-ci-examples) for more details.
 
 Once you have completed the code of your application, you can deploy the CDK stack using:
 
@@ -275,7 +275,7 @@ This will create an Ubuntu based container for building the Yocto images.
 
 > [!NOTE]
 >
-> We recommend you to deploy first the 'Base Image' pipeline and once the pipeline completes successfully, then you can deploy the other pipelines in you application as described in the [sample](github.com/aws4embeddedlinux/aws4embeddedlinux-ci-examples).
+> We recommend you to deploy first the 'Base Image' pipeline and once the pipeline completes successfully, then you can deploy the other pipelines in you application as described in the [sample](https://github.com/aws4embeddedlinux/aws4embeddedlinux-ci-examples).
 >
 
 Once your pipelines completes successfully, the Yocto deploy directory generated content will be pushed into a S3 bucket.

eslint.config.mjs

@@ -1,11 +1,12 @@
 import typescriptEslintEslintPlugin from "@typescript-eslint/eslint-plugin";
+import simpleImportSort from "eslint-plugin-simple-import-sort";
 import tsdoc from "eslint-plugin-tsdoc";
 import globals from "globals";
 import tsParser from "@typescript-eslint/parser";
 import path from "node:path";
 import { fileURLToPath } from "node:url";
-import eslint from "@eslint/js";
-import tseslint from "typescript-eslint";
+import eslintjs from "@eslint/js";
+import eslintts from "typescript-eslint";
 import { FlatCompat } from "@eslint/eslintrc";
 
 const __filename = fileURLToPath(import.meta.url);
@@ -16,14 +17,22 @@ const gitignorePath = path.resolve(__dirname, ".gitignore");
 
 const compat = new FlatCompat({
   baseDirectory: __dirname,
-  recommendedConfig: eslint.configs.recommended,
-  allConfig: eslint.configs.all,
+  recommendedConfig: eslintjs.configs.recommended,
+  allConfig: eslintjs.configs.all,
 });
 
 export default [
+  ...compat.extends(
+    "eslint:recommended",
+    "plugin:@typescript-eslint/recommended",
+    "plugin:prettier/recommended",
+  ),
+  ...eslintts.configs.recommended,
   {
+    ...eslintjs.configs.recommended,
     plugins: {
       "@typescript-eslint": typescriptEslintEslintPlugin,
+      "simple-import-sort": simpleImportSort,
       tsdoc,
     },
 
@@ -39,7 +48,7 @@ export default [
 
       parserOptions: {
         sourceType: "module",
-        project: "./tsconfig.json",
+        project: "./tsconfig.eslint.json",
       },
     },
 
@@ -61,8 +70,21 @@ export default [
       "prettier/prettier": [
         "error",
         {
-          singleQuote: true,
-          trailingComma: "es5",
+          singleQuote: false,
+          trailingComma: "all",
+        },
+      ],
+
+      "@typescript-eslint/no-unused-vars": [
+        "error",
+        {
+          args: "all",
+          argsIgnorePattern: "^_",
+          caughtErrors: "all",
+          caughtErrorsIgnorePattern: "^_",
+          destructuredArrayIgnorePattern: "^_",
+          varsIgnorePattern: "^_",
+          ignoreRestSiblings: true,
         },
       ],
     },
@@ -77,13 +99,6 @@ export default [
       "/test/**",
       "/tmp/**",
     ],
-    ...eslint.configs.recommended,
   },
   includeIgnoreFile(gitignorePath),
-  ...compat.extends(
-    "eslint:recommended",
-    "plugin:@typescript-eslint/recommended",
-    "plugin:prettier/recommended",
-  ),
-  ...tseslint.configs.recommended,
 ];

jest.config.js

@@ -1,13 +1,4 @@
 /* eslint-env node */
-// module.exports = {
-//   testEnvironment: "node",
-//   roots: ["<rootDir>/test"],
-//   testMatch: ["**/*.test.ts"],
-//   transform: {
-//     "^.+\\.tsx?$": "ts-jest",
-//   },
-// };
-
 export const testEnvironment = "node";
 export const roots = ["<rootDir>/test"];
 export const testMatch = ["**/*.test.ts"];

lib/codepipeline-embedded-linux.ts

@@ -49,7 +49,7 @@ export interface EmbeddedLinuxCodePipelineProps extends cdk.StackProps {
   readonly buildPolicyAdditions?: iam.PolicyStatement[];
   /** Additional build environment variables to the build project. */
   readonly environmentVariables?: {
-    string: codebuild.BuildEnvironmentVariable;
+    [key: string]: codebuild.BuildEnvironmentVariable;
   };
   /** The encryption key use across*/
   readonly encryptionKey: kms.Key;
@@ -272,12 +272,12 @@ export class EmbeddedLinuxCodePipelineStack extends cdk.Stack {
       project,
     });
 
-    const artifactAction: codepipeline_actions.S3DeployAction =
+    const outputAction: codepipeline_actions.S3DeployAction =
       new codepipeline_actions.S3DeployAction({
-        actionName: "Artifact",
+        actionName: "Output",
         input: buildActionOutputArtifact,
-        bucket: props.pipelineArtifactBucket,
-        objectKey: `${props.pipelineArtifactPrefix}/${sourceRepoAsset.s3ObjectKey}`,
+        bucket: props.pipelineOutputBucket,
+        objectKey: `${props.pipelineOutputPrefix}`,
       });
 
     /** Here we create the logic to check for presence of ECR image on the CodeCodePipeline automatic triggering upon resource creation,
@@ -352,8 +352,8 @@ export class EmbeddedLinuxCodePipelineStack extends cdk.Stack {
             actions: [buildAction],
           },
           {
-            stageName: "Artifact",
-            actions: [artifactAction],
+            stageName: "Output",
+            actions: [outputAction],
           },
         ],
       },

lib/index.ts

@@ -1,23 +1,8 @@
-import * as s3 from "aws-cdk-lib/aws-s3";
-
 export * from "./codebuild-embedded-linux";
 export * from "./codepipeline-embedded-linux-base-image";
 export * from "./codepipeline-embedded-linux";
 export * from "./codepipeline-resources";
 
-export function isBucketVersioned(bucket: s3.Bucket | s3.IBucket) {
-  const bucketCfn: s3.CfnBucket = bucket.node.defaultChild as s3.CfnBucket;
-  if (
-    bucketCfn.versioningConfiguration &&
-    (
-      bucketCfn.versioningConfiguration as s3.CfnBucket.VersioningConfigurationProperty
-    ).status != "Enabled"
-  ) {
-    return true;
-  }
-  return false;
-}
-
 /**
  * The type of project built.
  */

package.json

@@ -1,8 +1,8 @@
 {
   "name": "aws4embeddedlinux-cdk-lib",
   "version": "0.2.0",
-  "main": "dist/lib/index.js",
-  "types": "dist/lib/index.d.ts",
+  "main": "dist/index.js",
+  "types": "dist/index.d.ts",
   "license": "MIT",
   "scripts": {
     "build": "tsc",
@@ -11,17 +11,12 @@
     "doc": "typedoc --sort source-order --readme README.md",
     "format": "eslint '**/*.{js,ts,json}' --quiet --fix",
     "postinstall": "npm run build > /dev/null || echo 'prepapre command completed successfully with errors'",
-    "prepare": "npm run build > /dev/null || echo 'prepapre command completed successfully with errors'",
     "prepare-commit": "pre-commit run --all-files --color=always --show-diff-on-failure",
     "test": "jest",
     "update-snapshot": "jest -u",
     "watch": "tsc -w",
-    "postclean": "rm -rf ./dist",
-    "prebuild": "./utils/build-assets.sh",
     "precheck": "yarn clean",
-    "preformat": "yarn clean",
-    "pretest": "yarn prebuild",
-    "preupdate-snapshot": "yarn prebuild"
+    "preformat": "yarn clean"
   },
   "dependencies": {
     "aws-cdk-lib": "2.176.0",
@@ -40,6 +35,7 @@
     "eslint": "^9.16.0",
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-prettier": "^5.2.1",
+    "eslint-plugin-simple-import-sort": "^12.1.1",
     "eslint-plugin-tsdoc": "^0.4.0",
     "globals": "^15.13.0",
     "jest": "^29.7.0",