Add Spring Boot 4.0 support with working samples #1585
Conversation
bnusunny
left a comment
bnusunny
left a comment
There was a problem hiding this comment.
Looks good overall. Please check the two comments I left.
tobixlea
force-pushed
the
sjc-spring-boot-update
branch
26 times, most recently
from
d7dd038 to
52fedb7
Compare
tobixlea
force-pushed
the
sjc-spring-boot-update
branch
2 times, most recently
from
80b787b to
a5a34b5
Compare
tobixlea
force-pushed
the
sjc-spring-boot-update
branch
from
a5a34b5 to
b83323f
Compare
| <dependency> | ||
| <groupId>com.amazonaws.serverless</groupId> | ||
| <artifactId>aws-serverless-java-container-core</artifactId> | ||
| <version>${project.version}</version> |
There was a problem hiding this comment.
I don't know how this worked, but if it was this sort of variable ${project.version} we might want to keep it like that, so it's easier in the future to update? (unless there's a reason to not do it, and it should be mentioned in the PR description)
(same in other pom.xml files).
| <dependency> | ||
| <groupId>com.amazonaws.serverless</groupId> | ||
| <artifactId>aws-serverless-java-container-core</artifactId> | ||
| <version>3.0.0-SNAPSHOT</version> |
There was a problem hiding this comment.
We should use ${project.version} here
| <dependency> | ||
| <groupId>com.amazonaws.serverless</groupId> | ||
| <artifactId>aws-serverless-java-container-core</artifactId> | ||
| <version>3.0.0-SNAPSHOT</version> |
There was a problem hiding this comment.
same here. use ${project.version}
| <dependency> | ||
| <groupId>com.amazonaws.serverless</groupId> | ||
| <artifactId>aws-serverless-java-container-springboot4</artifactId> | ||
| <version>[2.0.0-SNAPSHOT,),[2.0.0-M1,)</version> |
There was a problem hiding this comment.
This version range is not right. Should be [3.0.0-SNAPSHOT,)
| <artifactId>aws-serverless-java-container-springboot4</artifactId> | ||
| <version>[2.0.0-SNAPSHOT,),[2.0.0-M1,)</version> | ||
| </dependency> | ||
| <!-- Add Jackson 2.x for core library compatibility --> |
There was a problem hiding this comment.
Do we still need this lib? Core lib requires Jackson 3.x now.
3 participants
Issue #, if available:
Description of changes:
${project.version}variable in archetype pom files in favor of explicit versioningBy submitting this pull request