feat: Support EndpointAccessMode property for AWS::Serverless::Api#3898
feat: Support EndpointAccessMode property for AWS::Serverless::Api#3898reedham-aws merged 3 commits intoaws:developfrom
Conversation
valerena
left a comment
There was a problem hiding this comment.
It looks good. We're checking with other people from the API Gateway service team to confirm that everything is okay.
iph
left a comment
There was a problem hiding this comment.
Thanks for the PR! Some minor suggestions here and there around testing (and the random comment :) ).
I'm fine with it being in a separate PR (I can handle it after), but this doesn't solve for all use cases of EndpointAccessMode.
Essentially, you can add tls policies in 2 places:
- Rest APIs
- Custom Domains
hence, those are also the places you can add EndpointAccessMode. This covers Rest APIs but does not cover Custom Domains.
|
Keen to have this so I can avoid adding a lot of CloudFormation 🙇 🙏 Thanks! |
|
support Custom Domains and enhance the unit and integration test |
|
lgtm! |
|
Thanks for the contribution! This still needs to go through a deployment through the different AWS regions, so it will still take some time to be fully available. |
Issue #, if available
#3866
Description of changes
The
SecurityPolicyproperty was added in a recent change.When specifying a policy that begins with SecurityPolicy_ in the
SecurityPolicyproperty, theEndpointAccessModeproperty must also be specified. This change is to pass through the EndpointAccessMode property directly to the API.https://docs.aws.amazon.com/apigateway/latest/developerguide/apigateway-security-policies.html#apigateway-security-policies-endpoint-access-mode
Description of how you validated changes
unit & integration test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.