-
Notifications
You must be signed in to change notification settings - Fork 2.5k
add integration test for LMI functions #3863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
integration/combination/test_function_with_capacity_provider.py
Outdated
Show resolved
Hide resolved
integration/resources/templates/combination/function_lmi_custom.yaml
Outdated
Show resolved
Hide resolved
integration/resources/templates/combination/function_lmi_custom.yaml
Outdated
Show resolved
Hide resolved
integration/resources/templates/combination/function_lmi_default.yaml
Outdated
Show resolved
Hide resolved
integration/combination/test_function_with_capacity_provider.py
Outdated
Show resolved
Hide resolved
integration/combination/test_function_with_capacity_provider.py
Outdated
Show resolved
Hide resolved
|
Run integration tests: |
integration/combination/test_function_with_capacity_provider.py
Outdated
Show resolved
Hide resolved
integration/combination/test_function_with_capacity_provider.py
Outdated
Show resolved
Hide resolved
- Refactor get_lambda_capacity_provider_config to accept capacity provider name directly - Use get_physical_id_by_logical_id at call sites for consistency - Extract duplicate validation logic into reusable helper methods: - verify_capacity_provider_basic_config - verify_capacity_provider_vpc_config - verify_capacity_provider_permissions_config - Remove unused local variables (capacity_provider, simple_capacity_provider, advanced_capacity_provider) This addresses review comments from valerena on Jan 16, 2026
integration/combination/test_function_with_capacity_provider.py
Outdated
Show resolved
Hide resolved
integration/combination/test_function_with_capacity_provider.py
Outdated
Show resolved
Hide resolved
… methods
- Move .get('VpcConfig') and .get('PermissionsConfig') inside verification methods
- Remove redundant inline comments that duplicate what the code clearly shows
- Simplify test methods by passing cp_config directly to verification methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed both comments:
- Moved
.get('VpcConfig')and.get('PermissionsConfig')inside the verification methods - Removed redundant inline comments
valerena
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You didn't necessarily have to remove all comments (only the ones that were just redundant), but it looks good to me now.
Issue #, if available
Add integration test for deploying application with CapacityProvider and LMI functions
Description of changes
Add test data and test cases for successfully deployment of resources.
Description of how you validated changes
Checklist
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.