fix: write ModelTrainer train script with LF line endings#5843
Open
JocelynBmnr wants to merge 2 commits into
Open
fix: write ModelTrainer train script with LF line endings#5843JocelynBmnr wants to merge 2 commits into
JocelynBmnr wants to merge 2 commits into
Conversation
…bug-in-modeltrainer fix: write ModelTrainer train script with LF line endings
JocelynBmnr
requested a deployment
to
manual-approval
GitHub Actions
Waiting
JocelynBmnr
requested a deployment
to
manual-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ModelTrainergeneratessm_train.sh, which is executed inside Linux training containers.On Windows, writing this generated shell script with platform-default text-mode newline handling can produce CRLF (
\r\n) line endings. Linux shell execution expects LF (\n) line endings, so generated shell scripts intended for Linux containers should be written with explicit LF newlines.This change writes the generated train script with
newline="\n"to avoid Windows-specific CRLF line endings.This mirrors the existing fix pattern used elsewhere in the SDK for generated shell scripts executed in Linux containers.