feat: add new field source to Nova config#397
Draft
amazeAmazing wants to merge 1 commit intoaws:release_v2from
Draft
feat: add new field source to Nova config#397amazeAmazing wants to merge 1 commit intoaws:release_v2from
amazeAmazing wants to merge 1 commit intoaws:release_v2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changing and why?
sourceunder therunconfig to contain what source triggered the SMHP job for Nova models. I am adjusting the validation to accept this new field.Before/After UX
Before:
User who pass a
sourcefield underrunfor Nova recipes failed validation.After:
User who pass a
sourcefield underrunfor Nova recipes pass validation.User experience will not change for users who directly use the Sagemaker Hyperpod CLI, as no recipes in the sagemaker-hyperpod-recipes package will change.
However, for customers who use the Nova Forge SDK, the Nova Forge SDK will populate this field in their recipe for SMHP Nova recipes.
How was this change tested?
Locally tested this change and validating that the training images supported this field.
Are unit tests added?
No
Are integration tests added?
No
Reviewer Guidelines
One of the following must be true: