chore: Add 4 new HyperPod GA regions and fix region fallback logic #360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #359
This ensures the health-monitoring-agent can pull images even when deployed in unmapped or future regions (if the cluster nodes have internet access).
What's changing and why?
Add support for 4 newly GA regions in health-monitoring-agent:
This brings total supported regions to 17 GA regions.
Fix fallback logic bug where unmapped regions would create malformed image URIs. Previously, when a region was not in the mapping, only the account ID would fallback to us-east-1 while the region remained unchanged, resulting in invalid URIs like below:
767398015722.dkr.ecr.ap-southeast-3.amazonaws.com/hyperpod-health-monitoring-agent:1.0.1038.0_1.0.305.0
Now both region AND account ID fallback together to us-east-1, generating valid URIs:
767398015722.dkr.ecr.us-east-1.amazonaws.com/hyperpod-health-monitoring-agent:1.0.1038.0_1.0.305.0
Before/After UX
Before:
For regions missing in the mapping, malformed URI would cause ECR image pull failure.
After:
For region missing in the mapping, URI would be constructed correctly and fall back to IAD region, if the cluster nodes have internet access then image pull will succeed.
How was this change tested?
1/ Created a cluster in
ca-central-1which is among the new regions being added.2/ Updated the helm chart dependencies after making the committed changes.
3/ Installed the updated helm charts
4/ Validated that the
health-monitoring-agentdaemonset constructed image URI for theca-central-1region correctly.5/ Also validated fallback case where the install command did not provide region explicitly and hence should fall back to IAD region as expected
Are unit tests added?
N/A
Are integration tests added?
N/A
Reviewer Guidelines
One of the following must be true: