Skip to content

In a subresource the parameter value will be an empty string.#2924

Closed
jeijei4 wants to merge 1 commit intoaws:masterfrom
jeijei4:patch-1
Closed

In a subresource the parameter value will be an empty string.#2924
jeijei4 wants to merge 1 commit intoaws:masterfrom
jeijei4:patch-1

Conversation

@jeijei4
Copy link
Copy Markdown

@jeijei4 jeijei4 commented May 17, 2024

Issue #, if available:

Description of changes:

The documentation explains:
when a request targets a subresource, the corresponding query parameter value will be an empty string ("").

Example:
"http://s3.amazonaws.com/examplebucket?acl"

The CanonicalQueryString in this case is as follows:

UriEncode("acl") + "=" + ""

https://docs.aws.amazon.com/IAM/latest/UserGuide/create-signed-request.html#create-canonical-request

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The documentation explains:
when a request targets a subresource, the corresponding query parameter value will be an empty string ("").

Example:
"http://s3.amazonaws.com/examplebucket?acl"

The CanonicalQueryString in this case is as follows:

UriEncode("acl") + "=" + ""


https://docs.aws.amazon.com/IAM/latest/UserGuide/create-signed-request.html#create-canonical-request
@stobrien89 stobrien89 closed this Mar 14, 2025
@stobrien89 stobrien89 reopened this Mar 14, 2025
@stobrien89 stobrien89 closed this Mar 27, 2026
@stobrien89 stobrien89 reopened this Mar 27, 2026
@stobrien89
Copy link
Copy Markdown
Member

Hi @jeijei4,

Thanks for the PR. Apologies for the delayed reply. Thanks for raising this — Psr7\Query::parse produces ['acl' => null] for subresource parameters, and the existing null-coalescing in getCanonicalizedQuery already handles this correctly by emitting acl= as the spec requires. No change is needed at this time.

@stobrien89 stobrien89 closed this Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants