Add support of Request-level credentials override in DefaultS3CrtAsyncClient#6793
Open
Add support of Request-level credentials override in DefaultS3CrtAsyncClient#6793
Conversation
dagnir
reviewed
Mar 17, 2026
| * Integration tests verifying that request-level credential overrides work correctly | ||
| * with the S3 CRT client. | ||
| */ | ||
| public class S3CrtRequestLevelCredentialsIntegrationTest extends S3IntegrationTestBase { |
Contributor
There was a problem hiding this comment.
Does this need to be an integration test? Can it be written to use wiremock?
Contributor
Author
There was a problem hiding this comment.
Good call. Changed to use wiremock instead.
dagnir
approved these changes
Mar 18, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR added support of Request-level credentials override in DefaultS3CrtAsyncClient and Closes #5354
Motivation and Context
Currently, the DefaultS3CrtAsyncClient throws UnsupportedOperationException when users provide request
-level credentials via AwsRequestOverrideConfiguration.credentialsIdentityProvider(). This PR added support for that and removes this exception.
Modifications
to carry the per-request CrtCredentialsProviderAdapter through SdkHttpExecutionAttributes.
credentialsIdentityProvider.
wraps them in a CrtCredentialsProviderAdapter and attaches it to the HTTP execution
attributes.
credentials when building the AwsSigningConfig.
callback on the request future to ensure the native CRT resource outlives the meta request.
Added unit test in in S3CrtAsyncHttpClientTest verifying the crt resources are properly closed in the signing config when provided.
Added wiremock test to test valid override succeeds.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License