-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: Add CloudFormation Language Extensions support (Fn::ForEach) #8637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bnusunny
wants to merge
26
commits into
develop
Choose a base branch
from
feat-language-extension
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
1ba2f02
feat: add CloudFormation Language Extensions processing library
bnusunny 5ca1763
feat: integrate language extensions into SAM CLI
bnusunny d267527
feat: add language extensions support to sam build
bnusunny ede506e
feat: add language extensions support to sam package and deploy
bnusunny adc02f6
test: add validate, local invoke, and start-api integration tests
bnusunny 8aa7044
feat: add telemetry tracking for CloudFormation Language Extensions
bnusunny 9f4b55a
test: trim language extensions integration tests to essential cases
bnusunny 4a852c2
fix: Fn::Equals uses string comparison to match CloudFormation behavior
bnusunny 3856180
fix: scope intrinsic resolution to Resources, Conditions, and Outputs…
bnusunny c3ef249
refactor: rename iter_resources to iter_regular_resources
bnusunny 563b84f
refactor: deduplicate _to_boolean and fix TOCTOU in expansion cache
bnusunny a0d7c4f
test: remove integration tests referencing deleted test data
bnusunny 2b7ee3b
refactor: address PR review comments on style and test quality
bnusunny cd65ba2
feat: add &{identifier} syntax support in Fn::ForEach expansion
bnusunny 452222a
fix: remove unsupported list-of-lists identifier format from Fn::ForEach
bnusunny bceb2b3
fix: use proper type annotation for intrinsic_resolver parameter
bnusunny 45941c4
fix: correct _process_section docstring about which sections it handles
bnusunny 115dbed
test: add tier1_extra markers and replace NamedTemporaryFile
bnusunny eaaf811
fix: narrow exception handling and bound expansion cache size
bnusunny 89d6013
test: add tests for cache eviction and narrowed exception handling
bnusunny 3732423
fix: improve error visibility and add UTF-8 encoding for file reads
bnusunny 2399047
fix: update test mocks to expect encoding='utf-8' parameter
bnusunny 578b2f2
fix: MissingMappingKeyError now extends DeployFailedError
bnusunny f34414d
fix: catch unexpected exceptions in child template expansion gracefully
bnusunny 903c812
fix: deep-copy original_template consistently in expand_language_exte…
bnusunny 5ad3477
test: verify original_template is independent from caller's input
bnusunny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Coverage config for `make test` which skips cfn_language_extensions tests. | ||
| # Extends the base .coveragerc and also excludes the language extensions source | ||
| # so coverage % isn't penalized when those tests are skipped. | ||
| [run] | ||
| branch = True | ||
| omit = | ||
| samcli/lib/cfn_language_extensions/* | ||
| # Inherited from .coveragerc | ||
| samcli/lib/iac/plugins_interfaces.py | ||
| samcli/lib/init/templates/* | ||
| samcli/hook_packages/terraform/copy_terraform_built_artifacts.py | ||
| [report] | ||
| exclude_lines = | ||
| pragma: no cover | ||
| raise NotImplementedError.* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.