Skip to content

fix: remove autoreconf to prevent hang on ARM platforms (#121) #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhinav-mangla wants to merge 1 commit into
base: nodejs24.x
Choose a base branch
from
+9 −5
Open

fix: remove autoreconf to prevent hang on ARM platforms (#121) #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Dockerfile.native
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,9 @@ RUN cd /tmp && \

# Build curl
WORKDIR /tmp/curl
RUN autoreconf -fiv && \
CFLAGS="$CURL_CFLAGS" LDFLAGS="$CURL_LDFLAGS" ./configure \
# Skip autoreconf - the curl tarball includes a pre-generated configure script
# Running autoreconf hangs on ARM platforms due to bash/libtool/autoconf issue
RUN CFLAGS="$CURL_CFLAGS" LDFLAGS="$CURL_LDFLAGS" ./configure \
--prefix /build/deps \
--disable-alt-svc \
--disable-ares \
Expand Down
9 changes: 6 additions & 3 deletions scripts/preinstall.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,12 @@ fi
echo "Building curl..."
(
cd "$CURL_DIR"
# Only run autoreconf if configure doesn't exist or is older than configure.ac
if [ ! -f configure ] || [ configure.ac -nt configure ]; then
autoreconf -fiv
# The curl tarball includes a pre-generated configure script.
# We skip autoreconf as it hangs on ARM platforms due to a known
# bash/libtool/autoconf interaction issue.
if [ ! -f configure ]; then
echo "Error: configure script not found in curl archive" >&2
exit 1
fi
./configure \
--prefix "$ARTIFACTS_DIR" \
Expand Down