Skip to content

Conversation

@wangyb-A
Copy link
Contributor

@wangyb-A wangyb-A commented Oct 8, 2025

  • feat: add validation for wait seconds less than 1

@wangyb-A wangyb-A requested a review from yaythomas October 8, 2025 22:13
Copy link
Member

@yaythomas yaythomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type check failing for 3.11

@wangyb-A
Copy link
Contributor Author

wangyb-A commented Oct 8, 2025

type check failing for 3.11

I believe it fails for hatch issue - in the log the env failed to be created, which means the actually type check failed to start.

@wangyb-A wangyb-A marked this pull request as ready for review October 9, 2025 15:38
@wangyb-A wangyb-A requested a review from yaythomas October 9, 2025 15:40
Copy link
Member

@yaythomas yaythomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do a local rework of the commits, so feat commit is distinct to ci commit.

@wangyb-A wangyb-A merged commit 4ff2546 into aws:main Oct 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants