fix: retries optional not set #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix retry strategy to only apply default error patterns when neither retryable_errors nor retryable_error_types is specified, matching the behavior of the JS/TS SDK. Previously, specifying only one filter would still apply defaults, causing unintended retry behavior. Also fix critical jitter calculation bug where jitter was being added to base delay instead of replacing it, effectively doubling delays. - Change RetryStrategyConfig fields to None defaults - Apply default patterns only when both filters are None - Rename compute_jitter to apply_jitter for clarity - Fix apply_jitter to return final delay not additive amount - Update test expectations to match corrected jitter behavior - Add missing math import to waits.py
Prevent ruff fmt errors since experimental is on
leandrodamascena
requested changes
Nov 27, 2025
Contributor
leandrodamascena
left a comment
leandrodamascena
left a comment
There was a problem hiding this comment.
Just one small comment, but lgtm.
ParidelPooya
previously approved these changes
Nov 27, 2025
wangyb-A
previously approved these changes
Nov 27, 2025
yaythomas
dismissed stale reviews from wangyb-A and ParidelPooya
via
588bb44
leandrodamascena
approved these changes
Nov 27, 2025
wangyb-A
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fix retry strategy to only apply default error patterns when neither retryable_errors nor retryable_error_types is specified, matching the behavior of the JS/TS SDK. Previously, specifying only one filter would still apply defaults, causing unintended retry behavior.
Also fix critical jitter calculation bug where jitter was being added to base delay instead of replacing it, effectively doubling delays.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.