Skip to content

fix: validate checkpoint token hasnt been used #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bchampp wants to merge 1 commit into from
Closed

fix: validate checkpoint token hasnt been used #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/aws_durable_execution_sdk_python_testing/executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ def get_execution_state(
execution = self.get_execution(execution_arn)

# TODO: Validate checkpoint token if provided
if checkpoint_token and checkpoint_token not in execution.used_tokens:
if checkpoint_token and checkpoint_token in execution.used_tokens:
msg: str = f"Invalid checkpoint token: {checkpoint_token}"
raise InvalidParameterValueException(msg)

Expand Down Expand Up @@ -469,7 +469,7 @@ def checkpoint_execution(
execution = self.get_execution(execution_arn)

# Validate checkpoint token
if checkpoint_token not in execution.used_tokens:
if checkpoint_token in execution.used_tokens:
msg: str = f"Invalid checkpoint token: {checkpoint_token}"
raise InvalidParameterValueException(msg)

Expand Down
8 changes: 4 additions & 4 deletions tests/executor_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1916,7 +1916,7 @@ def test_get_execution_state(executor, mock_store):

mock_store.load.return_value = mock_execution

result = executor.get_execution_state("test-arn", checkpoint_token="token1") # noqa: S106
result = executor.get_execution_state("test-arn", checkpoint_token="token3") # noqa: S106

assert len(result.operations) == 2
assert result.next_marker is None
Expand All @@ -1932,7 +1932,7 @@ def test_get_execution_state_invalid_token(executor, mock_store):
with pytest.raises(
InvalidParameterValueException, match="Invalid checkpoint token"
):
executor.get_execution_state("test-arn", checkpoint_token="invalid-token") # noqa: S106
executor.get_execution_state("test-arn", checkpoint_token="token1") # noqa: S106


def test_get_execution_history(executor, mock_store):
Expand All @@ -1954,7 +1954,7 @@ def test_checkpoint_execution(executor, mock_store):
mock_execution.get_new_checkpoint_token.return_value = "new-token"
mock_store.load.return_value = mock_execution

result = executor.checkpoint_execution("test-arn", "token1")
result = executor.checkpoint_execution("test-arn", "new-token")

assert result.checkpoint_token == "new-token" # noqa: S105
assert result.new_execution_state is None
Expand All @@ -1971,7 +1971,7 @@ def test_checkpoint_execution_invalid_token(executor, mock_store):
with pytest.raises(
InvalidParameterValueException, match="Invalid checkpoint token"
):
executor.checkpoint_execution("test-arn", "invalid-token")
executor.checkpoint_execution("test-arn", "token1")


# Callback method tests
Expand Down
Loading