fix: rename wait options model from seconds to wait_seconds #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchampp
force-pushed
the
fix/wait-options
branch
from
eff0472 to
ae7b1c5
Compare
bchampp
commented
Oct 7, 2025
| on: | ||
| push: | ||
|
|
||
| branches: [ main ] |
Member
Author
There was a problem hiding this comment.
This fixes the duplicate workflows we'd see in PRs for both pull_request and push.
Member
There was a problem hiding this comment.
it does... but you lose CI build on branches. e.g if you're working on FeatureA and you push intermediate work (without PRing it), you don't get a CI build anymore.
Not necessarily the end of the world, though.
Member
Author
There was a problem hiding this comment.
We could add a wildcard branch for this like ci-feat-* if you need to run CI before creating a PR.
wangyb-A
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Updating
WaitOptionsto usewait_secondsinstead ofsecondsto match the API spec.Dependencies
If this PR requires testing against a specific branch of the Python Language SDK (e.g., for unreleased changes), uncomment and specify the branch below. Otherwise, leave commented to use the main branch.
PYTHON_LANGUAGE_SDK_BRANCH: fix-wait-deserialization
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.