Skip to content

feat: Implement callback for web runner#114

Merged
wangyb-A merged 1 commit intomainfrom
web_callback
Nov 13, 2025
Merged

feat: Implement callback for web runner#114
wangyb-A merged 1 commit intomainfrom
web_callback

Conversation

@wangyb-A
Copy link
Copy Markdown
Contributor

  • Implement async run, send callback for web runner
  • Unit tests

Issue #, if available:

Description of changes:

Dependencies

If this PR requires testing against a specific branch of the Python Language SDK (e.g., for unreleased changes), uncomment and specify the branch below. Otherwise, leave commented to use the main branch.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@wangyb-A
Copy link
Copy Markdown
Contributor Author

I have ran some wait_for_callback integration tests with web runner successfully. We can't add those tests because the unit tests which depend on local runner will fail because the callback feature (#95) change has not been merged.

@wangyb-A wangyb-A marked this pull request as ready for review November 13, 2025 00:53
Comment thread src/aws_durable_execution_sdk_python_testing/runner.py Outdated
Comment thread src/aws_durable_execution_sdk_python_testing/runner.py Outdated
Comment thread src/aws_durable_execution_sdk_python_testing/runner.py Outdated
@wangyb-A wangyb-A force-pushed the web_callback branch 3 times, most recently from 13876ab to a6c9ff3 Compare November 13, 2025 19:54
Comment thread src/aws_durable_execution_sdk_python_testing/runner.py Outdated
- Implement async run, send callback for web runner
- Unit tests
@wangyb-A wangyb-A merged commit dbb5903 into main Nov 13, 2025
32 checks passed
@wangyb-A wangyb-A deleted the web_callback branch November 13, 2025 23:09

def send_callback_success(self, callback_id: str) -> None:
try:
self.lambda_client.send_durable_execution_callback_success(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update this to support the optional Result field. Same for error on callback failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants