[v2] Add ability to get values from properties in subsections#10112
Draft
kdaily wants to merge 5 commits intofeature-configure-subsectionsfrom
Draft
[v2] Add ability to get values from properties in subsections#10112kdaily wants to merge 5 commits intofeature-configure-subsectionsfrom
kdaily wants to merge 5 commits intofeature-configure-subsectionsfrom
Conversation
ashovlin
reviewed
Mar 4, 2026
Member
ashovlin
left a comment
ashovlin
left a comment
There was a problem hiding this comment.
Could we also add an example or two for get?
| # distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF | ||
| # ANY KIND, either express or implied. See the License for the specific | ||
| # language governing permissions and limitations under the License. | ||
| import re |
Member
There was a problem hiding this comment.
Don't see usage of this in the diff?
| else: | ||
| return None | ||
| else: | ||
| return section_config.get(varname) |
Member
There was a problem hiding this comment.
aws configure get --sso-session non-existent sso_region
'NoneType' object has no attribute 'get'
Can we throw a nicer error when the sub-section doesn't exist? And expand the test for this case to check more than exit code?
Something like we do for profiles?
aws configure get region --profile non-existent
The config profile (non-existent) could not be found
Rename and add more test cases to cover non-exsistent subsections and nested properties.
Member
Author
Addressed in 4574a20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Continuation of #10109.
Description of changes:
This change adds new parameters to the
aws configure getcommand to specify a sub-section for getting the value of a property. These parameters are analogous to the existing--profileparameter. A parameter will be added for each sub-section type and take a value of the subsection name. Following is the generic pattern for theaws configure getcommand:For example, the following command should get the property
sso_regionfrom thesso-sessionsub-section namedmy-sso-session:Following is an example getting a nested property in a sub-section:
The only sub-section types allowed are
servicesandsso-session.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.