Skip to content

Remove unnecessary .dist-info directories from executable#10042

Merged
ashovlin merged 2 commits intoaws:v2from
ashovlin:shovlia/clean-dist-info
Feb 3, 2026
Merged

Remove unnecessary .dist-info directories from executable#10042
ashovlin merged 2 commits intoaws:v2from
ashovlin:shovlia/clean-dist-info

Conversation

@ashovlin
Copy link
Member

Issue #, if available: #10037

Description of changes:

In #9552, we removed the code that removed .dist-info directories when building the AWS CLI executable. This was done for prompt-toolkit, which needed its directory to resolve __version__.

Now, this PR adds back the removal code with a carve out for prompt-toolkit. This should avoid the .dist-info for wheel being included from the internal build system, which will avoid false-positives from scanners.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

hssyoo
hssyoo previously approved these changes Jan 29, 2026
Copy link
Contributor

@hssyoo hssyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming builds pass 🏆

@hssyoo hssyoo self-requested a review February 1, 2026 20:19
@hssyoo hssyoo dismissed their stale review February 1, 2026 20:19

Need iteration

@ashovlin ashovlin merged commit bb8f729 into aws:v2 Feb 3, 2026
61 of 107 checks passed
@ashovlin ashovlin deleted the shovlia/clean-dist-info branch February 3, 2026 18:32
cavcrosby pushed a commit to cavcrosby/aws-cli that referenced this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants