fix: class var threads #1090
Open
fix: class var threads #1090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faviansamatha
force-pushed
the
fix/class-var-threads
branch
3 times, most recently
from
022dcaf to
d0e922d
Compare
faviansamatha
force-pushed
the
fix/class-var-threads
branch
from
d0e922d to
95534b1
Compare
karenc-bq
reviewed
Jan 30, 2026
| WrapperProperties.CLUSTER_TOPOLOGY_HIGH_REFRESH_RATE_MS.get_int(self._props) * 1_000_000) | ||
|
|
||
| self._monitors = SlidingExpirationCacheContainer.get_or_create_cache( | ||
| name=self._MONITOR_CACHE_NAME, |
Contributor
There was a problem hiding this comment.
Do we want to treat these monitor cache names as class var
Contributor
There was a problem hiding this comment.
Same question for the cleanup nanos
Contributor
Author
There was a problem hiding this comment.
I think we should treat them as class variables. As a "single source of truth", since we don't want anything else that uses the classes to have different configurations.
karenc-bq
reviewed
Jan 30, 2026
| def release_resources(): | ||
| MonitoringRdsHostListProvider._monitors.clear() | ||
| # Note: Monitors are now managed by SlidingExpirationCacheContainer | ||
| # and will be cleaned up via cleanup.release_resources() |
Contributor
There was a problem hiding this comment.
Can we log a deprecation message here and tell users to switch to
from aws_advanced_python_wrapper import AwsWrapperConnection, release_resources
aws_advanced_python_wrapper .release_resources()instead? if they are not already calling that.
Contributor
Author
There was a problem hiding this comment.
I ended up deleting it as this wasn't released yet, and we only used it inside our integration tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, any class variables with SlidingExpirationCacheWithCleanupThreads will automatically be initialized when anything in that file is imported. This means that even if users don't use plugins that require this, we would be spawning 5 threads for other classes. This is not ideal.
This PR containerizes replaces all SlidingExpirationCacheWithCleanupThreads with SlidingExpirationCache. In this container, we will run only 1 thread that will cleanup all these caches every 5 minutes. This thread will not be spawned until the first time we make a pool.
Furthermore this optimizes instances that uses ThreadPoolContainer by just storing a reference to the ThreadPool that the class uses. This is an improvement because anytime a class uses a thread pool container, it would not have to fight for the lock.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.