fix(pg): prevent process crash during Aurora failover#621
Open
fix(pg): prevent process crash during Aurora failover#621
Conversation
Two issues cause Node.js process to crash when an Aurora failover occurs: 1. AwsPgInternalPoolClient creates a pg.Pool without an 'error' event handler. During failover, idle connections are terminated by the server, emitting 'error' events on the pool. Without a handler, Node.js throws an uncaught exception and the process exits. 2. AwsPGPooledConnection.release() unconditionally calls this.targetClient.client.release(), but after failover the new client may not have a release() method (e.g., a direct connection rather than a pooled connection), causing a TypeError. Fix 1: Attach a no-op 'error' handler to the internal pg.Pool so idle connection errors are swallowed. The failover plugin handles reconnection. Fix 2: Check if release() exists on the underlying client before calling it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve #620
Description
Two issues cause Node.js process to crash when an Aurora failover occurs:
AwsPgInternalPoolClient creates a pg.Pool without an 'error' event handler. During failover, idle connections are terminated by the server, emitting 'error' events on the pool. Without a handler, Node.js throws an uncaught exception and the process exits.
AwsPGPooledConnection.release() unconditionally calls this.targetClient.client.release(), but after failover the new client may not have a release() method (e.g., a direct connection rather than a pooled connection), causing a TypeError.
Fix 1: Attach a no-op 'error' handler to the internal pg.Pool so idle connection errors are swallowed. The failover plugin handles reconnection.
Fix 2: Check if release() exists on the underlying client before calling it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.