fix: extract Architecture-Group-Icons from AWS icon ZIP#151
Merged
ShotaroKataoka merged 3 commits intoMay 20, 2026
Conversation
added 2 commits
May 18, 2026 21:13
The download_aws_icons.py ZIP filter only extracted 48px SVGs, missing the Architecture-Group-Icons directory which uses 32px. As a result, icons referenced by ARCH_GROUP_DEFS (AWS-Cloud-logo, Region, VPC, public/private-subnet, Auto-Scaling-group, Account, etc.) were absent from assets/aws/ on a fresh install, causing arch-group elements to fail with `Asset not found: AWS-Cloud-logo_32`. - Extract _should_extract() helper that allows 32px in Architecture-Group-Icons paths and 48px elsewhere - Add unit tests for _should_extract and _classify_type covering service / resource / category / group classifications
…_entry The neighboring helpers in this module (`_classify_type`, `_extract_category`, `_name_from_filename`, `_generate_tags`) all use a verb+object form. A boolean predicate fits better as `is_*` per PEP 8, and `_is_target_entry` reads naturally next to `_classify_type` since both classify a ZIP entry. Also reword the docstring as a predicate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
download_aws_icons.pyZIP filter only extracted 48px SVGs, missing theArchitecture-Group-Icons_*/directory which uses 32px. As a result, icons referenced byARCH_GROUP_DEFS(AWS-Cloud-logo, Region, VPC, public/private-subnet, Auto-Scaling-group, Account, etc.) were absent fromassets/aws/after a fresh install, causingarch-groupelements to fail with:Changes
_should_extract()helper that allows 32px inArchitecture-Group-Iconspaths and 48px elsewhere_should_extractand_classify_typecovering service / resource / category / group classificationsTest plan
uv run pytest tests/(188 passed, 1 skipped — 12 new tests)uv run ruff check(clean)download_aws_icons.py: manifest entries 843 → 858 (+15 group icons, including all icons referenced byARCH_GROUP_DEFS)arch-group: aws-cloud / vpc / regionand confirmed group icons display correctly viapptx_builder generate+ LibreOffice PNG export