feat: support folded_corner preset shape#150
Draft
mskt4440 wants to merge 2 commits into
Draft
Conversation
- Map folded_corner -> MSO_SHAPE.FOLDED_CORNER in builder - Allow folded_corner in lint _SHAPE_NAMES - Round-trip foldedCorner -> folded_corner in converter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for the
folded_cornerpreset shape, mirroring the existingmath_not_equal/cylinderpatterns.folded_corner->MSO_SHAPE.FOLDED_CORNERin the builderfolded_cornerin the lint_SHAPE_NAMESallowlistfoldedCorner->folded_cornerin the converterTest plan
uv run pytest tests/(176 passed, 1 skipped)uv run ruff check(clean)folded_corner(filled#FF9900) alongside a plain rectangle control viapptx_builder generate+ LibreOffice PNG export. The folded-corner notch renders as expected.