Fix comparing resource clients with differing lists not raising an error#1106
Open
Liam-DeVoe wants to merge 1 commit intoaws-cloudformation:masterfrom
Open
Fix comparing resource clients with differing lists not raising an error#1106Liam-DeVoe wants to merge 1 commit intoaws-cloudformation:masterfrom
Liam-DeVoe wants to merge 1 commit intoaws-cloudformation:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation of
item_hash(used byResourceClient.compare) used an in-place.sortmethod. This returnsNonefor all lists, which means that resource clients which differ in that list will incorrectly appear as if they were equal. To confirm this, I have added a test which fails on master.fwiw: I found this bug during a research project I'm working on which uses LLMs to write property-based tests in Hypothesis. This property, that different lists hash to different values, was proposed and written "autonomously" by the agent. I wrote this PR myself and take full responsibility for it.
(By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.)