fix(cli): classify migration categories by prefix#14901
Open
hariharan077 wants to merge 1 commit into
Open
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14609.
extractCategory()previously classified logical IDs by checking whether category names appeared anywhere in the ID. That made the result order-dependent, so a storage resource such asstorageauthbackupwas reported asAuthbecauseauthappeared later in the resource name.This changes category detection to use known Amplify category prefixes and keeps core infrastructure detection prefix-based as well.
Validation
storageauthbackupreturnedAuthinstead ofStorage.corepack yarn workspace @aws-amplify/cli-internal test src/__tests__/commands/gen2-migration/_common/categories.test.ts --runInBand --no-coveragecorepack yarn workspace @aws-amplify/cli-internal test src/__tests__/commands/drift --runInBand --no-coveragecorepack yarn workspace @aws-amplify/cli-internal test src/__tests__/commands/gen2-migration/_common/categories.test.ts src/__tests__/commands/drift/services/drift-formatter.test.ts --runInBand --no-coveragecorepack yarn prettier --check packages/amplify-cli/src/commands/gen2-migration/_common/categories.ts packages/amplify-cli/src/__tests__/commands/gen2-migration/_common/categories.test.tscorepack yarn eslint packages/amplify-cli/src/commands/gen2-migration/_common/categories.ts packages/amplify-cli/src/__tests__/commands/gen2-migration/_common/categories.test.tscorepack yarn sanitize-migration-appscorepack yarn build-tests-changedgit diff --check