fix: throw ArgumentOutOfRangeException when times of For is not positive

[vbreuss]

This PR adds validation to ensure that the times parameter in the For method is positive, throwing an ArgumentOutOfRangeException when it's not. This prevents undefined behavior when users accidentally pass zero or negative values.

Key Changes:

• Added input validation to the For method in Callback.cs to throw ArgumentOutOfRangeException when times <= 0
• Added test coverage for the validation with parameterized tests checking both negative and zero values
• Tests verify the exception message matches the expected "Times must be greater than zero." prefix

[Copilot]

Pull request overview

This PR adds validation to ensure that the times parameter in the For method is positive, throwing an ArgumentOutOfRangeException when it's not. This prevents undefined behavior when users accidentally pass zero or negative values.

Changes:

• Added input validation to the For method in Callback.cs to throw ArgumentOutOfRangeException when times <= 0
• Added test coverage for the validation with parameterized tests checking both negative and zero values
• Tests verify the exception message matches the expected "Times must be greater than zero." prefix

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
Source/Mockolate/Setup/Callback.cs	Added validation logic to throw ArgumentOutOfRangeException when times parameter is not positive
Tests/Mockolate.Tests/MockMethods/SetupMethodTests.CallbackTests.cs	Added parameterized tests for For and Only methods to verify exception is thrown for invalid times values
Tests/Mockolate.Tests/MockProperties/SetupPropertyTests.OnGetTests.cs	Added parameterized test for property setup For method to verify exception is thrown for invalid times values

[github-actions]

Test Results

    14 files  ± 0      14 suites  ±0   5m 10s ⏱️ -5s
 2 171 tests + 6   2 170 ✅ + 6  1 💤 ±0  0 ❌ ±0 
14 532 runs  +42  14 531 ✅ +42  1 💤 ±0  0 ❌ ±0 

Results for commit 8446014. ± Comparison against base commit ecb3045.

♻️ This comment has been updated with latest results.

[github-actions]

🚀 Benchmark Results

Details

BenchmarkDotNet v0.15.8, Linux Ubuntu 24.04.3 LTS (Noble Numbat)

Intel Xeon Platinum 8370C CPU 2.80GHz, 1 CPU, 4 logical and 2 physical cores

.NET SDK 10.0.102

[Host] : .NET 10.0.2 (10.0.2, 10.0.225.61305), X64 RyuJIT x86-64-v4
Job=InProcess  Toolchain=InProcessEmitToolchain  IterationCount=15

LaunchCount=1  WarmupCount=10

Method	Mean	Error	StdDev	Gen0	Gen1	Allocated
Simple_Mockolate	1.521 μs	0.0321 μs	0.0300 μs	0.1507	-	3.72 KB
Simple_Moq	135.896 μs	0.6852 μs	0.6074 μs	0.4883	0.2441	14.72 KB
Simple_NSubstitute	5.595 μs	0.0810 μs	0.0757 μs	0.3662	-	9.14 KB
Simple_FakeItEasy	5.829 μs	0.0497 μs	0.0465 μs	0.3281	-	8.12 KB

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

[Copilot]

The test validates the For method but uses Returns("") which tests a different code path than the callback-focused Do() method. Consider adding a test that uses .Do(() => { }).For(times) to match the property setup test pattern and ensure validation works consistently across both setup approaches.

[Copilot]

The test validates the Only method but uses Returns("") which tests a different code path than the callback-focused Do() method. Consider adding a test that uses .Do(() => { }).Only(times) to match the property setup test pattern and ensure validation works consistently across both setup approaches.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

This is addressed in release v0.52.0.