-
-
Notifications
You must be signed in to change notification settings - Fork 0
fix: correctly escape generic types in generated XML-Doc #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes XML documentation generation for generic types by ensuring proper XML escaping of type parameters in generated documentation comments.
Changes:
- Added
.EscapeForXmlDoc()calls to generic type parameters in method/delegate signatures within XML documentation - Added test case to verify mocking of protected virtual members
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Source/Mockolate.SourceGenerators/Sources/Sources.ForMock.Extensions.cs | Applied XML escaping to generic type parameters in four locations where method/delegate parameter types appear in XML doc comments |
| Tests/Mockolate.Tests/Protected/ProtectedMockTests.cs | Added test case for mocking classes with only protected virtual members |
🚀 Benchmark ResultsDetails
|
ce8a9a7 to
ad27a1d
Compare
|
|
This is addressed in release v0.52.0. |



This PR fixes XML documentation generation for generic types by ensuring proper XML escaping of type parameters in generated documentation comments.
Key Changes:
.EscapeForXmlDoc()calls to generic type parameters in method/delegate signatures within XML documentation