feat: add --extra-header flag for custom gRPC headers#588
feat: add --extra-header flag for custom gRPC headers#588sputnikraket wants to merge 1 commit intoauthzed:mainfrom
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
I think this is fine, but what's the use case? I'm wondering if it's something that zed already supports. |
We're running SpiceDB behind a proxy that requires authentication (GCP Cloud Run), that can be specified either through the This setup is perhaps not ideal, but it works. |
tstirrat15
left a comment
There was a problem hiding this comment.
See question; otherwise LGTM
| md := metadata.New(headers) | ||
| ctx = metadata.NewOutgoingContext(ctx, md) |
There was a problem hiding this comment.
Does this logic functionally merge the headers, or would this overwrite headers if some other component added new headers?
Signed-off-by: Erik Hennings <erik.hennings@freda.com>
8637ea4 to
67dafa8
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #588 +/- ##
==========================================
- Coverage 41.72% 41.49% -0.23%
==========================================
Files 38 38
Lines 6131 6172 +41
==========================================
+ Hits 2558 2561 +3
- Misses 3317 3354 +37
- Partials 256 257 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Erik Hennings erik.hennings@freda.com
Description
This PR adds support for passing custom headers to gRPC requests via a new
--extra-headerflag.Testing
Manual testing
References