fix: prevent path traversal in config file handlers#1388
Open
ankita10119 wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1388 +/- ##
==========================================
- Coverage 79.84% 79.81% -0.04%
==========================================
Files 153 153
Lines 7052 7055 +3
Branches 1547 1547
==========================================
Hits 5631 5631
- Misses 781 783 +2
- Partials 640 641 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Fixes a path traversal vulnerability in config file handlers where user-supplied file paths in configuration (e.g.
code,customScripts) could reference files outside the config directory using sequences like../../.Changes:
DirectoryContext.loadFile: Resolves the final path and validates it stays within the config root before loading. Removes the previous fallback that silently tried the raw path if the relative path didn't exist, that fallback was the entry point for traversalyaml/index.ts: Same boundary check applied to the YAML context'sloadFile, throwing an explicit error if the resolved path escapes the config directorydatabases.ts: Added config root boundary check forcustomScriptsfile paths defined indatabase.jsonactions.ts/actionModules.ts: Removed thefs.existsSyncbranch that allowed absolute or root-relative paths to bypass the relative-path resolution, paths are now always resolved relative to the handler folder📚 References
🔬 Testing
./actions/code.js) instead of absolute paths, reflecting the new enforcement that file references must stay within the config directorypage.htmlinstead of an absolute path, and fixed file write ordering to match the new resolution logic../../etc/passwdas a script path) will now throw an explicit error rather than silently loading the file📝 Checklist